Remove unused pk_and_sequence_for in AbstractMysqlAdapter
#21686
Conversation
|
r? @senny (@rails-bot has picked a reviewer for you, use r? to override) |
|
This method appears in the documentation (which may have been accidental) so we'd need to deprecate it first before we remove it. |
|
+Deprecation, but that only covers callers of this method. I'd guess that most usage is people overriding/patching the method to change its behavior, and that will no longer work anyway. Removing the method would cause the overrides to fail, which may be easier to understand than a deprecation. https://github.com/search?l=ruby&q=pk_and_sequence_for&type=Code&utf8=✓ |
|
r? @jeremy |
kamipo
force-pushed
the
remove_pk_and_sequence_for
branch
from
ab31620
to
5e8f502
Compare
|
@arthurnn I rebased it, thanks! |
|
Also, can you add a note on the Changelog for it. as it was part of the Docs, and we are removing it without deprecation, I would say it is nice to have it in the logs. |
`pk_and_sequence_for` is implemented for PG and MySQL adapters (not implemented for Sqlite3 adapter). But MySQL adapters are not using `pk_and_sequence_for` already.
kamipo
force-pushed
the
remove_pk_and_sequence_for
branch
from
5e8f502
to
fd37486
Compare
|
I added to the Changelog. |
Remove unused `pk_and_sequence_for` in AbstractMysqlAdapter
|
@kamipo thanks! 👍 |
|
Thank you for quick merging 😄 |
…comment is not used/needed
pk_and_sequence_foris implemented for PG and MySQL adapters (notimplemented for Sqlite3 adapter). But MySQL adapters are not using
pk_and_sequence_foralready. We can remove the method.