Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update routing.rb #21694

Merged
merged 1 commit into from
Sep 20, 2015
Merged

Update routing.rb #21694

merged 1 commit into from
Sep 20, 2015

Conversation

harrykiselev
Copy link
Contributor

forgotten end of the block

forgotten end of the block
@rails-bot
Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @sgrif (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@jeremy
Copy link
Member

jeremy commented Sep 20, 2015

Thanks @harrykiselev !

(Note: when no code changes are made, you can add [ci skip] to your commit message to skip the CI run, saving time and resources.)

jeremy added a commit that referenced this pull request Sep 20, 2015
Docs typo: missing `end` in routing.rb
@jeremy jeremy merged commit a9f83b6 into rails:master Sep 20, 2015
@harrykiselev
Copy link
Contributor Author

Thanks for your note, @jeremy .
I will be more accurate next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants