Fix a bug with returning_disabled when using the postgresql adapter #21697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @senny (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
The returning_disabled configuration option is required to make postgresql partitioning triggers work. This commit fixes a bug where an invalid query would be made in cases where returning_disabled was true and objects were created with no attributes defined.
gdeglin
force-pushed
the
fix_returning_disabled_default_values_bug
branch
from
ad47a84
to
871f453
Compare
|
For extra clarity on this bug and fix, here's a very simple failing testcase: https://gist.github.com/gdeglin/a32541807ba366d57c57 The stack trace of the failure is: You can see that Rails attempted to query a non-existent sequence. This is because it fails to fetch the table name correctly. This patch corrects a regular expression so that it does correctly fetch the table name in this case, and then queries the correct sequence. |
| assert_equal expect.to_i, result.rows.first.first | ||
| end | ||
|
|
||
|
|
There was a problem hiding this comment.
Please be more prudent about whitespace issues like this (your end lines had trailing whitespace as well). We have to merge manually from the command line to fix issues like this, which takes a lot more time and means we can process fewer issues each day.
There was a problem hiding this comment.
I'll keep this in mind for next time. Thanks!
sgrif
added a commit
that referenced
this pull request
Sep 24, 2015
…_values_bug Fix a bug with returning_disabled when using the postgresql adapter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The returning_disabled configuration option is required to make postgresql partitioning triggers work. This commit fixes a bug where an invalid query would be made in cases where returning_disabled was true and objects were created with no attributes defined.
This fixes one of the issues I identified in #21659