Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Action View Overview Guide] Add note about Jbuilder #21740

Merged
merged 1 commit into from
Sep 24, 2015

Conversation

cllns
Copy link
Contributor

@cllns cllns commented Sep 23, 2015

Currently, the Action View Overview talks about Builder, but doesn't mention Jbuilder.

Jbuilder is included in the default Gemfile (when running rails new app_name), so I think it deserves some mention in the guides. It's one of the only gems in there that doesn't get mentioned (the other s sdoc).

My impression is that JBuilder is currently used to render views more often than Builder.

Would be willing to expand this a little bit, but also reduce it to an INFO or TIP box.

Thoughts?

@rails-bot
Copy link

r? @senny

(@rails-bot has picked a reviewer for you, use r? to override)

@senny
Copy link
Member

senny commented Sep 24, 2015

@cllns thank you 💛 The addition goes well with what we have on Builder already. Length and depth are fine. Readers looking for details should consult the Jbuilder docs.

@senny senny merged commit 9617799 into rails:master Sep 24, 2015
senny added a commit that referenced this pull request Sep 24, 2015
[ci skip]

[Action View Overview Guide] Add note about Jbuilder
@senny
Copy link
Member

senny commented Sep 24, 2015

@cllns I changed the a tags to markdown markup in the merge commit (8516d76)

@senny senny added the docs label Sep 24, 2015
@cllns
Copy link
Contributor Author

cllns commented Sep 24, 2015

Awesome. thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants