Add missing routing tests for info controller #21776
Conversation
|
r? @eileencodes (@rails-bot has picked a reviewer for you, use r? to override) |
|
@aditya-kapoor thanks for the PR. 😄 I think the commit message should have more detail about why you added these tests - meaning explain what was missing that you wanted to add them. |
|
@eileencodes thanks for the review... Should I change the commit message? This is vaguely related to #21605 where I proposed to remove this |
|
Yes I'm just asking you to change the commit message. It's better for Rails in the long term to have commit messages that explain why we made changes. |
aditya-kapoor
force-pushed
the
add-missing-tests-info
branch
from
bb6347a
to
b5e82d9
Compare
Vaguely related to rails#21605 where I proposed to remove index route since it was redirecting to the 'routes' action, but this was kept so I thought it made sense to add some tests regarding this.
|
@eileencodes I have updated the commit message...:smiley: |
Add missing routing tests for info controller
|
By the way, I just noticed you had a typo in your test. Fixed in 0ce3b97 |
No description provided.