Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix proper fonts in change_column_null method docs. [ci skip] #21788

Merged
merged 1 commit into from
Sep 27, 2015

Conversation

amitsuroliya
Copy link
Contributor

Right now, change_column_null method docs showing +NOT NULL+ and +NULL+s. See -
screen shot 2015-09-27 at 2 50 36 pm
After this change, change_column_null method docs will show proper fonts. See -
screen shot 2015-09-27 at 3 13 43 pm

@rails-bot
Copy link

r? @pixeltrix

(@rails-bot has picked a reviewer for you, use r? to override)

@fxn
Copy link
Member

fxn commented Sep 27, 2015

The markup is correct, but the apostrophe is not needed. NULLs is the normal way you pluralize.

@amitsuroliya
Copy link
Contributor Author

@fxn Updated PR. Thanks for review ❤️

fxn added a commit that referenced this pull request Sep 27, 2015
Fix proper fonts in `change_column_null` method docs. [ci skip]
@fxn fxn merged commit 587e285 into rails:master Sep 27, 2015
@amitsuroliya amitsuroliya deleted the doc_fixes branch September 27, 2015 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants