Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci skip] Fix explanation of ActiveModel::Serialization #21809

Merged
merged 1 commit into from
Oct 2, 2015

Conversation

yui-knk
Copy link
Contributor

@yui-knk yui-knk commented Sep 29, 2015

This explanation was change by 7a27de2b.
This change reversed the including module (ActiveModel::Serializers::JSON)
and the included module (ActiveModel::Serialization) by mistake.

@rails-bot
Copy link

r? @sgrif

(@rails-bot has picked a reviewer for you, use r? to override)

@yui-knk
Copy link
Contributor Author

yui-knk commented Sep 29, 2015

r? @robin850

@rails-bot rails-bot assigned robin850 and unassigned sgrif Sep 29, 2015
# The JSON serialization is provided by default when you include the
# <tt>ActiveModel::Serialization</tt> module, so there is no need to explicitly
# include it.
# <tt>ActiveModel::Serializers::JSON</tt> module automatically includes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't wrap things which could link in the docs. RDoc should automatically replace this with a link to the actual documentation for that module.

This explanation was change by rails@7a27de2b.
This change reversed the including module (`ActiveModel::Serializers::JSON`)
and the included module (`ActiveModel::Serialization`) by mistake.
@yui-knk
Copy link
Contributor Author

yui-knk commented Oct 2, 2015

@sgrif unwrapped! :)

sgrif added a commit that referenced this pull request Oct 2, 2015
[ci skip] Fix explanation of `ActiveModel::Serialization`
@sgrif sgrif merged commit 7e6d1f1 into rails:master Oct 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants