Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ActiveSupport::TimeWithZone documentation #22119

Merged
merged 2 commits into from
Oct 29, 2015

Conversation

philr
Copy link
Contributor

@philr philr commented Oct 29, 2015

This pull request adds documentation for ActiveSupport::TimeWithZone#ago and ActiveSupport::TimeWithZone#advance.

It also fixes the example given in the documentation for ActiveSupport::TimeWithZone#- (the stated value of now in the example would actually give the same result for now - 24.hours and now - 1.day).

The stated value of `now` would actually give the same result for
`now - 24.hours` and `now - 1.day`. Use an alternative value for
`now` that demonstrates the difference between subtracting
`24.hours` and `1.day`.
@rails-bot
Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @rafaelfranca (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

pixeltrix added a commit that referenced this pull request Oct 29, 2015
ActiveSupport::TimeWithZone documentation
@pixeltrix pixeltrix merged commit 97b3603 into rails:master Oct 29, 2015
@pixeltrix
Copy link
Contributor

@philr thanks for the PR! When providing documentation only updates please can you append [ci skip] to the commit message to spare our poor overworked CI servers 😄 - thanks again.

@philr philr deleted the time_with_zone_documentation branch October 29, 2015 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants