Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify automatic creation/deletion of join models for has_many through #22203

Merged

Conversation

cllns
Copy link
Contributor

@cllns cllns commented Nov 6, 2015

Fix a couple formatting things (missing : before code block, and capitalization after code block), and clarify the language.

@rails-bot
Copy link

r? @eileencodes

(@rails-bot has picked a reviewer for you, use r? to override)

@eileencodes
Copy link
Member

Hey @cllns thanks for the PR! I think the anchor is incorrect, I think it should be going to #the-has-many-association. Can you check on that?

@cllns
Copy link
Contributor Author

cllns commented Nov 6, 2015

I think it's correct! Since the code specifically refers to a helper method, I think it makes more sense to link down to the list of helper methods. I could switch it to #methods-added-by-has-many, but they're basically the same (since it's only a few lines below what #has-many-association-reference) and pointing to #has-many-association-reference provides some useful context.

For reference:

@eileencodes
Copy link
Member

Thanks I couldn't find it, wasn't sure where it was pointing too.

eileencodes added a commit that referenced this pull request Nov 6, 2015
Clarify automatic creation/deletion of join models for has_many through
@eileencodes eileencodes merged commit 79d310f into rails:master Nov 6, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants