Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comma to to make the information clear #22211

Merged
merged 1 commit into from
Nov 7, 2015
Merged

Add comma to to make the information clear #22211

merged 1 commit into from
Nov 7, 2015

Conversation

atul-shimpi
Copy link
Contributor

http://guides.rubyonrails.org/form_helpers.html

5.2 Dealing with Ajax
Unlike other forms making an asynchronous file upload form is not as simple as providing form_for with remote: true.

Insert comma after 'Unlike other forms.' as shown below
Unlike other forms, making an asynchronous file upload form is not as simple as providing form_for with remote: true.

@rails-bot
Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @eileencodes (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@kaspth
Copy link
Contributor

kaspth commented Nov 7, 2015

Thanks! In future documentation changes add [ci skip] to the start of your commit message, that way our CI won't run needlessly 😄

kaspth added a commit that referenced this pull request Nov 7, 2015
Add comma to to make the information clear
@kaspth kaspth merged commit af3ac50 into rails:master Nov 7, 2015
@atul-shimpi
Copy link
Contributor Author

ok.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants