Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

possible fix for deprecating config.action_view.debug_rjs= #2223

Closed
wants to merge 1 commit into from

Conversation

cldwalker
Copy link
Contributor

I can write tests for this as needed

@fxn
Copy link
Member

fxn commented Jul 24, 2011

I see your point, but I think such a message could be confusing. People using RJS today will be using that configuration option in 3.1. It is not exactly deprecated.

The switch to jQuery and the extraction of Prototype and RJS are important known changes in 3.1. You need to be aware of them if you're upgrading an application. In particular, if you're not using Prototype you need to remove that line.

Thanks for the pull request anyway.

@fxn fxn closed this Jul 24, 2011
@cldwalker
Copy link
Contributor Author

I was basically trying to solve the issue brought up in #2098. The wording of the deprecation can change but it still seems to be an outstanding issue.

@fxn
Copy link
Member

fxn commented Jul 24, 2011

Ah, I see. Then it makes sense that this is coherent, I'll reopen.

@fxn fxn reopened this Jul 24, 2011
@fxn
Copy link
Member

fxn commented Jul 24, 2011

I checked it, and the warning actually gets printed. That happens in 3-0-stable. As the message says everything related to RJS is removed from 3.1, so I don't really see this message in 3-1-stable.

@fxn fxn closed this Jul 24, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants