Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add days_in_year method to Time class #22244

Merged
merged 1 commit into from
Nov 10, 2015
Merged

Conversation

pacso
Copy link
Contributor

@pacso pacso commented Nov 10, 2015

Adds a days_in_year method to the Time class.

Returns 365 for common years and 366 for leap years.

@rails-bot
Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @matthewd (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@pixeltrix
Copy link
Contributor

@pacso can you add a CHANGELOG entry please - thanks

@pacso
Copy link
Contributor Author

pacso commented Nov 10, 2015

@pixeltrix - Have added an entry to the activesupport CHANGELOG now.

Cheers,
Jon

@pixeltrix
Copy link
Contributor

@pacso sorry to be a pain, but could you please squash them into a single commit - thanks

@pacso
Copy link
Contributor Author

pacso commented Nov 10, 2015

@pixeltrix no problem at all. Should already be done.

pixeltrix added a commit that referenced this pull request Nov 10, 2015
Add days_in_year method to Time class
@pixeltrix pixeltrix merged commit 6c3db36 into rails:master Nov 10, 2015
@pixeltrix
Copy link
Contributor

@pacso thanks for your contribution!

@pacso pacso deleted the time-days-in-year branch November 10, 2015 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants