Clearer comment and variable name on IP spoofing #22372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @schneems (@rails-bot has picked a reviewer for you, use r? to override) |
| # Since we have no idea, we give up and explode. | ||
| # If they are both set, it means that either: | ||
| # | ||
| # 1) this request passed through two proxies with incompatible IP header |
There was a problem hiding this comment.
Capitalize each number list entry. i.e. "This" instead of "this". Don't end with an "or". They are separate list entries and should stand on their own. End each list entry in a period.
|
@schneems - updated. |
|
thanks 🚀 |
schneems
added a commit
that referenced
this pull request
Nov 23, 2015
Clearer comment and variable name on IP spoofing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes digging into an
IpSpoofAttackErroreasier:check_ip_spoofinglocal variable toip_spoofing_check(which is the name used everywhere else)IpSpoofAttackErrorto give details of how the error could be raised by user behaviour, not just proxy configuration.Hopefully uncontroversial, and makes the IP spoofing check a lot easier to understand.