Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove extra spaces from deprecation message #22596

Merged

Conversation

y-yagi
Copy link
Member

@y-yagi y-yagi commented Dec 15, 2015

# before
DEPRECATION WARNING:               Time columns will become time zone aware in Rails 5.1. This
              still causes `String`s to be parsed as if they were in `Time.zone`,
              and `Time`s to be converted to `Time.zone`.

              To keep the old behavior, you must add the following to your initializer:

                  config.active_record.time_zone_aware_types = [:datetime]

              To silence this deprecation warning, add the following:

                  config.active_record.time_zone_aware_types << :time
# after
DEPRECATION WARNING: Time columns will become time zone aware in Rails 5.1. This
still causes `String`s to be parsed as if they were in `Time.zone`,
and `Time`s to be converted to `Time.zone`.

To keep the old behavior, you must add the following to your initializer:

    config.active_record.time_zone_aware_types = [:datetime]

To silence this deprecation warning, add the following:

    config.active_record.time_zone_aware_types << :time

@rails-bot
Copy link

r? @eileencodes

(@rails-bot has picked a reviewer for you, use r? to override)

@kaspth
Copy link
Contributor

kaspth commented Dec 15, 2015

You need to require the core_ext files that implement the methods you've added, so the isolation tests that run on merges pass. Thanks 😁

```
# before
DEPRECATION WARNING:               Time columns will become time zone aware in Rails 5.1. This
              still causes `String`s to be parsed as if they were in `Time.zone`,
              and `Time`s to be converted to `Time.zone`.

              To keep the old behavior, you must add the following to your initializer:

                  config.active_record.time_zone_aware_types = [:datetime]

              To silence this deprecation warning, add the following:

                  config.active_record.time_zone_aware_types << :time
```

```
# after
DEPRECATION WARNING: Time columns will become time zone aware in Rails 5.1. This
still causes `String`s to be parsed as if they were in `Time.zone`,
and `Time`s to be converted to `Time.zone`.

To keep the old behavior, you must add the following to your initializer:

    config.active_record.time_zone_aware_types = [:datetime]

To silence this deprecation warning, add the following:

    config.active_record.time_zone_aware_types << :time
```
@y-yagi y-yagi force-pushed the remove_extra_space_from_deprecation_msg branch from 32d8e91 to 08780ef Compare December 15, 2015 10:33
@y-yagi
Copy link
Member Author

y-yagi commented Dec 15, 2015

oops sorry. I added the necessary require, and ran the isolation test.
Thanks for reviewing!

eileencodes added a commit that referenced this pull request Dec 15, 2015
…tion_msg

remove extra spaces from deprecation message
@eileencodes eileencodes merged commit e73fe1d into rails:master Dec 15, 2015
@eileencodes
Copy link
Member

Thanks! 😄

@y-yagi
Copy link
Member Author

y-yagi commented Dec 15, 2015

Thanks!

@y-yagi y-yagi deleted the remove_extra_space_from_deprecation_msg branch December 15, 2015 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants