Add code statistics for Javascript and CoffeeScript files to rake stats task
#2270
Conversation
|
What about the stylesheets then ? |
| comment_pattern = /^\s*\/\// | ||
| elsif file_name =~ /.*\.coffee$/ | ||
| comment_pattern = /^\s*#/ | ||
| end |
There was a problem hiding this comment.
I think a when/case would be more appropriate here (and it'd allow you to avoid repeting the same comment_pattern for rb and coffee.
There was a problem hiding this comment.
Do you mean something like this?
case file_name
when /.*\.js$/
comment_pattern = /^\s*\/\//
else
comment_pattern = /^\s*#/
end
There was a problem hiding this comment.
why not just use /^\s*(#|\/\/)/ as comment pattern?
There was a problem hiding this comment.
That'd probably suffice. You'd match // comments in rb files which isn't correct, but that's a pretty unlikely way to start a line of code!
I made it explicit so that you get an association between file extensions and comment syntaxes, and because it's more easily extended for other file types.
|
I'm not sure about including stylesheets. In my mind they fall into a different category to application code and client-side code. I guess this wouldn't matter except that the aggregate stats (Code LOC, Test LOC, Code to Test Ratio) could be skewed significantly by them. What do you think? |
|
@josevalim While you're tackling code stats (#4478) can you please take a look at this pull request too? |
|
+1 |
2 similar comments
|
+1 |
|
+1 |
As a general note, you can rebase whatever in your branch, and then force push, and GitHub will update the pull request properly. |
|
I think in this case, a new pull request needs to be sent because this one targets branch 3-1-stable and pull requests should be sent for master. Thanks!! |
CoffeeScript files to `rake stats` task Orignal PR was rails#2270 Thanks to @nfm
|
Closed by #6566 |
First time contributor so I'm not sure if I'm 'doing it right'. Should I rebase on master and submit a second pull request?