Add colored output to the new test reporter. #22756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
+1 I always wondered why Rails doesn't include this by default! |
|
LGTM |
kaspth
added a commit
that referenced
this pull request
Dec 23, 2015
…tput Add colored output to the new test reporter.
|
Sweet, @lucasmazza 👏 |
|
👏 |
|
@lucasmazza: Great. 👏 |
|
🌈 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds green/red/yellow ANSI color codes to
Rails::TestUnitReporterand enables it by default (based on a CLI flag).The output on iTerm's "Dark Background" preset:
If we want a programatic way to disable this, we could add a class attribute to be the fallback value in case the CLI flag isn't present, so developers can disable the colouring forever on their
test_helper.rb(a counterpart to RSpec's.rspecconfig file) - let me know if makes sense to add this to this PR./cc @kaspth 😄