Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo on documentation #22780

Merged
merged 1 commit into from Dec 24, 2015
Merged

Fix typo on documentation #22780

merged 1 commit into from Dec 24, 2015

Conversation

pauloancheta
Copy link
Contributor

Just missed an s.

@rails-bot
Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @matthewd (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@schneems
Copy link
Member

Thanks!

schneems added a commit that referenced this pull request Dec 24, 2015
@schneems
Merge pull request #22780 from pauloancheta/master
7aa047b 
Fix typo on documentation
@schneems schneems merged commit 7aa047b into rails:master Dec 24, 2015
@swrobel
Copy link
Contributor

swrobel commented Feb 12, 2020

FYI this was an intentional "typo" showing the incorrect behavior. The example in the docs now makes no sense. Actual behavior:

>> "Calculus".classify
=> "Calculu"

kamipo added a commit that referenced this pull request Feb 13, 2020
@kamipo
Revert "Merge pull request #22780 from pauloancheta/master"
76ae3db 
This reverts commit 7aa047b, reversing
changes made to c9b36dd.

This is a right example for singular names.
@kamipo
Copy link
Member

kamipo commented Feb 13, 2020

You are right, I've reverted it and add a test for the incorrect behavior. 76ae3db

kamipo added a commit that referenced this pull request Feb 13, 2020
@kamipo
Revert "Merge pull request #22780 from pauloancheta/master"
7e26044 
This reverts commit 7aa047b, reversing
changes made to c9b36dd.

This is a right example for singular names.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@matthewd matthewd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@pauloancheta @rails-bot @schneems @swrobel @kamipo @matthewd