Restore ability to pass extra options to cache stores #22800
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR restores the ability to pass options to the cache helper methods which will be passed on the cache store. This functionality worked in 4.x.
The
cache
helper methods are supposed to pass any extra options to the cache store. For example :expires_in would be a valid option if memcache was the cache store.The change in commit da16745 inadvertently broke the ability to pass any options other than :skip_digest and :virtual_path when some methods were changed to use keyword arguments.