Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better example for ActiveRecord::Relation#or #22860

Merged
merged 1 commit into from
Jan 1, 2016

Conversation

tasandberg
Copy link
Contributor

The old example could have been achieved with .where(id: [1, 2]), I thought this illustrated the new feature a bit better.

@rails-bot
Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @senny (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

claudiob added a commit that referenced this pull request Jan 1, 2016
Better example for ActiveRecord::Relation#or [ci skip]
@claudiob claudiob merged commit f263e25 into rails:master Jan 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants