4.1 Backport of LoggerSilence#silence Threadsafety patch (see: PR #20507) #22968
Conversation
rabbitt
commented
Jan 7, 2016
rabbitt
commented
- Uses Logger instance defined level if no custom local log level defined
- Keeps track of local log level per logger instance + thread id
- Prevents memory leakage by removing local level hash key/value on #silence method exit
- Test case for threadsafety issue added (and passes with these changes), based @rdubya's tests
- Fixes Rails.logger log level is not thread safe #20490 and supersedes Added thread-safety to LoggerSilence #16885
…ls#20507) - Uses Logger instance defined level if no custom local log level defined - Keeps track of local log level per logger instance + thread id - Prevents memory leakage by removing local level hash key/value on #silence method exit - Test case for threadsafety issue added (and passes with these changes), based @rdubya's tests - Fixes rails#20490 and supersedes rails#16885
|
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @pixeltrix (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
|
|
@rafaelfranca Here's the PR for the 4.1 backport, with travis all 💚 |
|
@rafaelfranca how does the process differ on backports compared to mainline PR's ? Is there anything else I need to do to move this forward? |
|
Not sure if we are still backporting patches to 4-1-stable... |
…fety 4.1 Backport of LoggerSilence#silence Threadsafety patch (see: PR #20507)
