Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unmangaling reverse_sql_order when function is used #2309

Merged
merged 1 commit into from Jul 27, 2011

Conversation

smasry
Copy link

@smasry smasry commented Jul 27, 2011

Reverse order fix when using function for ActiveRecord::QueryMethods Fixes #1697
Allowing the split to not to mangle the functions in the order clause

tenderlove added a commit that referenced this pull request Jul 27, 2011
Unmangaling reverse_sql_order when function is used
@tenderlove tenderlove merged commit 9d396ee into rails:master Jul 27, 2011
jonleighton added a commit that referenced this pull request Jul 28, 2011
This reverts commit 9d396ee, reversing
changes made to fa2bfd8.

Reason: the change broke the build.
jonleighton added a commit that referenced this pull request Aug 13, 2011
This reverts commit 9d396ee, reversing
changes made to fa2bfd8.

Reason: the change broke the build.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ActiveRecord::QueryMethods#reverse_sql_order mangles functions
4 participants