Fix the order of create_table to match a comment about `:inverse_of…
#23094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am not sure if this comment is useful at all TBH. Seems like it confuses things more than it helps. I would 🔥 it. |
|
I agree 😍 Can I remove these comments and fix order of tables on this PR ?? |
|
Yeah, please, go ahead and remove the comment. ❤️ |
…` options In ActiveRecord test :men, :faces, :interests and :zines tables are used for `:inverse_of` test cases, not `:wheels`.
These comment sometimes explain a face which does not match the face.
yui-knk
force-pushed
the
fix_ar_test_comment
branch
from
b64328c
to
4360ecf
Compare
|
@arthurnn I rebased. Can you review this? 🙏 |
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…` options
In ActiveRecord test :men, :faces, :interests and :zines tables are
used for
:inverse_oftest cases, not:wheels.