Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

insert newlines into code samples in Upgrading section of Asset Pipeline doc #23150

Merged
merged 1 commit into from
Jan 21, 2016

Conversation

alxndr
Copy link
Contributor

@alxndr alxndr commented Jan 21, 2016

I noticed some odd-looking code samples when reading over the Asset Pipeline doc on RailsGuides; thought I'd try to fix it up.

@rails-bot
Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @kaspth (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@maclover7
Copy link
Contributor

Please add [ci skip] to the commit message for documentation only changes in the future.

@alxndr
Copy link
Contributor Author

alxndr commented Jan 21, 2016

Whoops, thanks @maclover7! (my first Rails pr...)

@maclover7
Copy link
Contributor

No problem! If you'd like to, you can rebase or amend your commit and add ci skip so that way I can merge your PR faster! :)

@alxndr
Copy link
Contributor Author

alxndr commented Jan 21, 2016

Shall do!

@maclover7
Copy link
Contributor

👍 Thank you for your contribution!

maclover7 added a commit that referenced this pull request Jan 21, 2016
insert newlines into code samples in Upgrading section of Asset Pipeline doc
@maclover7 maclover7 merged commit c555c03 into rails:master Jan 21, 2016
@maclover7
Copy link
Contributor

❤️ 💚 💙 💛 💜

@alxndr
Copy link
Contributor Author

alxndr commented Jan 21, 2016

Glad to help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants