When generating a mailer, you must specify Mailer in the class name #23500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
order to generate the proper files. Some of the docs/comments are missing this important detail.
|
No code changes, just comments and USAGE docs. |
rafaelfranca
added a commit
that referenced
this pull request
Feb 5, 2016
When generating a mailer, you must specify Mailer in the class name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The usage docs for generating a mailer are missing Mailer in the name of the mailer. If you don't add Mailer to the name, your views and tests are generated incorrectly.
Based on the existing docs, if you do this:
rails generate mailer School welcomeThe views will be put in app/views/school and the tests will refer to a School class.
You must run the generator like this:
rails generate mailer SchoolMailer welcomeThese comment and usage changes reflect this requirement.