Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ActiveRecord::ValueTooLong exception class #23522

Merged
merged 1 commit into from
Apr 19, 2016

Conversation

kamipo
Copy link
Member

@kamipo kamipo commented Feb 6, 2016

No description provided.

@kamipo kamipo force-pushed the add_value_too_long_exception_class branch from ba9840a to 6efd02e Compare February 6, 2016 14:27
kamipo added a commit to kamipo/rails that referenced this pull request Feb 12, 2016
In MySQL, PostgreSQL, Oracle and SQLServer, a value over the limit
cannot be inserted or updated (See rails#23522).

In SQLite3, a value is inserted or updated regardless of the limit.

We should avoid a string value truncation in uniqueness validation.
@kamipo
Copy link
Member Author

kamipo commented Feb 17, 2016

r? @rafaelfranca

@jeremy
Copy link
Member

jeremy commented Apr 19, 2016

Merged 446190f

@jeremy jeremy closed this Apr 19, 2016
@jeremy jeremy added this to the 5.0.0 milestone Apr 19, 2016
@jeremy jeremy merged commit 6efd02e into rails:master Apr 19, 2016
jeremy added a commit that referenced this pull request Apr 19, 2016
Add `ActiveRecord::ValueTooLong` exception class
@kamipo kamipo deleted the add_value_too_long_exception_class branch April 19, 2016 06:18
yahonda added a commit to yahonda/oracle-enhanced that referenced this pull request May 3, 2016
and supress `DEPRECATION WARNING: Passing #original_exception is deprecated and has no effect. Exceptions will automatically capture the original exception. `

Refer:
rails/rails#23522
rails/rails#18774
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants