Set database poolsize via rails_max_threads #23528
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced in #23057 was an environment variable
RAILS_MAX_THREADS
that is used to set the number of threads in puma, the default web server. The default value for this environment variable is5
because that matches the default number of ActiveRecord threads. A mismatch between the database poolsize and the puma thread-count results inActiveRecord::ConnectionTimeoutError
.This PR proposes to also reuse the
RAILS_MAX_THREADS
when setting the database pool size to better ensure that the values are in sync.