Dump indexes in create_table for generates SQL in one query
#23557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @pixeltrix (@rails-bot has picked a reviewer for you, use r? to override) |
kamipo
force-pushed
the
dump_indexes_in_create_for_generates_sql_in_one_query
branch
4 times, most recently
from
ab68a2c
to
156879c
Compare
|
r? @jeremy |
kamipo
force-pushed
the
dump_indexes_in_create_for_generates_sql_in_one_query
branch
3 times, most recently
from
b29f568
to
16c547b
Compare
|
r? @sgrif |
kamipo
force-pushed
the
dump_indexes_in_create_for_generates_sql_in_one_query
branch
3 times, most recently
from
ab0e89c
to
b8f213a
Compare
kamipo
force-pushed
the
dump_indexes_in_create_for_generates_sql_in_one_query
branch
from
b8f213a
to
6847740
Compare
kamipo
force-pushed
the
dump_indexes_in_create_for_generates_sql_in_one_query
branch
from
6847740
to
8be8684
Compare
kamipo
force-pushed
the
dump_indexes_in_create_for_generates_sql_in_one_query
branch
from
8be8684
to
616947f
Compare
|
This looks to me. Rebase master? |
kamipo
force-pushed
the
dump_indexes_in_create_for_generates_sql_in_one_query
branch
from
616947f
to
2c5cebf
Compare
|
Rebased on master! |
kamipo
force-pushed
the
dump_indexes_in_create_for_generates_sql_in_one_query
branch
from
2c5cebf
to
d1f3e19
Compare
If the adapter supports indexes in create table, it generates SQL in one query.
kamipo
force-pushed
the
dump_indexes_in_create_for_generates_sql_in_one_query
branch
from
d1f3e19
to
74b5112
Compare
jeremy
added a commit
that referenced
this pull request
Apr 20, 2016
…rates_sql_in_one_query Dump indexes in `create_table` for generates SQL in one query
kamipo
deleted the
dump_indexes_in_create_for_generates_sql_in_one_query
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reopen #19994.
#19994 was reverted by d666a5a after beta2 for indexing materialized views.
(See scenic-views/scenic#135 in https://github.com/thoughtbot/scenic)
This PR keeps the old behavior method to address to scenic-views/scenic#135.
By this PR, it generates SQL in one query for each tables in MySQL (related with #20009).