Add response.parsed_body to Integration Tests

[kaspth]

Follow up to #21671

Fixes #23594

[rafaelfranca]

[kaspth]

Passed on this earlier build, https://travis-ci.org/rails/rails/builds/108383081, before I force pushed some changelog changes.

[dhh]

Would be nice if this was memoized. Frequent to have a bunch of checks against response.parsed_body['key1'], response.parsed_body['key2'].

[dhh]

We should extend this to work for the get case as well and whenever format is set:

  get circle_people_url(format: :json)
  assert_equal "something", response.parsed_body['key'] 

Right now it doesn't as format isn't used to detect the mime.

[dhh]

This should be: post articles_path, params: { article: { title: 'Ahoy!' } }, as: :json

[kaspth]

Doh! 😁

[kaspth]

@dhh ah, you'd like us to replace as with just format: :json on the URL? Don't know whether or not that introduces edge cases because we'd have to parse the returned URL string a bit.

[dhh]

I'd like for response.parsed_body to work if the response is encoded as
JSON. Shouldn't be dependent on as: :json.

On Thu, Feb 11, 2016 at 2:00 PM, Kasper Timm Hansen <
notifications@github.com> wrote:

@dhh https://github.com/dhh ah, you'd like us to replace as with just format:
:json on the URL? Don't know whether or not that introduces edge cases
because we'd have to parse the returned URL string a bit.

—
Reply to this email directly or view it on GitHub
#23597 (comment).

[matthewd]

Yeah, this shouldn't need to be based on the request encoding at all: the response headers tell us whether the response is JSON.

[kaspth]

@matthewd ah, of course 👍. Will patch this up tonight.

[kaspth]

@dhh @matthewd fixed your suggestions here f9f98b7...036a7a0

[dhh]

Super!

On Feb 11, 2016, at 22:51, Kasper Timm Hansen notifications@github.com wrote:

@dhh @matthewd fixed your suggestions here f9f98b7...036a7a0

—
Reply to this email directly or view it on GitHub.

[kaspth]

@dhh wups! Just noticed this doesn't work with format: :json calls. I'll look into it.

[f3ndot]

I noticed this still doesn't work with RSpec unit testing controllers for v5.2.4.3:

RSpec.describe Api::MyApi, type: :controller do
  controller do
    def create
      render json: { foo: 'bar' }
    end
  end

  it do
    # trying to do all forms of informing the testing framework that we're a JSON request
    @request.headers['Accept'] = 'application/json'
    @request.headers['Content-Type'] = 'application/json'
    post :create, as: :json, format: :json
    expect(response.parsed_body).to eq( 'foo' => 'bar' ) # fails
  end
end

Inspecting the code, it looks like this is because the @request is instantiated long before post() is invoked (during ActionController::TestCase::Behavior#setup_controller_request_and_response) where content-type is nil and thus the IdentityEncoder is used, not the json parsing lambda.

As far as I can see, additional work is required to change the @response_parser in TestResponse to match whatever the latest assigned content_type is on time of controller execution