Resolve warnings by checking if @attributes is defined #2363
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When @attributes is undefined (in the case of some of the tests using
.allocate
instead of.new
on an AR class) a warning will be thrown.As this adds an extra conditional it could be a performance hit but I suspect the only time anybody is really calling
#inspect
on an AR object is from within the console so it shouldn't be a big deal.