Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds missing tests for Digestor#nested_dependencies #23662

Merged

Conversation

rthbound
Copy link
Contributor

I realized the tests were missing when I made an intentionally breaking change to ActionView::Digestor#nested_dependencies:

-        dependencies.empty? ? dependency : { dependency => dependencies }
+        dependencies.any? ? dependency : { dependency => dependencies }

That change, while obviously breaking, did not result in any test breakage.
I've added the two test cases that should have broken... My intentional breakage causes the tests added here to fail as follows:

  1) Failure:
TemplateDigestorTest#test_getting_of_doubly_nested_dependencies [/home/rth/Software/rails/actionview/test/template/digestor_test.rb:140]:
--- expected
+++ actual
@@ -1 +1 @@
-[{"comments/comments"=>["comments/comment"]}, "messages/message"]
+["comments/comments", {"messages/message"=>[]}]



  2) Failure:
TemplateDigestorTest#test_getting_of_singly_nested_dependencies [/home/rth/Software/rails/actionview/test/template/digestor_test.rb:135]:
--- expected
+++ actual
@@ -1 +1 @@
-["messages/header", "messages/form", "messages/message", "events/event", "comments/comment"]
+[{"messages/header"=>[]}, {"messages/form"=>[]}, {"messages/message"=>[]}, {"events/event"=>[]}, {"comments/comment"=>[]}]

@rails-bot
Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @senny (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

senny added a commit that referenced this pull request Feb 17, 2016
…deps-tests

adds missing tests for Digestor#nested_dependencies
@senny senny merged commit 735e56e into rails:master Feb 17, 2016
@senny
Copy link
Member

senny commented Feb 17, 2016

@rthbound thanks 💛.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants