Passing table_name to Column#initialize to avoid instance_variable_set
#23677
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @kaspth (@rails-bot has picked a reviewer for you, use r? to override) |
kamipo
force-pushed
the
passing_table_name_to_column_initialize
branch
from
2690047
to
3c52111
Compare
…ctly working Currently the results of `column.serial?` is not correct. For `column.serial?` correctly working, initialize `column.table_name` immediately.
kamipo
force-pushed
the
passing_table_name_to_column_initialize
branch
from
3c52111
to
6b6a01c
Compare
rafaelfranca
added a commit
that referenced
this pull request
Mar 11, 2016
…itialize Passing `table_name` to `Column#initialize` to avoid `instance_variable_set`
kamipo
added a commit
to kamipo/rails
that referenced
this pull request
Apr 8, 2019
The `table_name` was added at rails#23677 to detect whether serial column or not correctly. We can do that detection before initialize column object, it makes column object size smaller, and it probably helps column object de-duplication.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.