Make sure the parameter parsers register API work with overidden mime types. #23816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After registering new `:json` mime type `parsers.fetch` can't find the mime type because new mime type is not equal to old one. Using symbol of the mime type as key on parsers hash solves the problem. Closes #23766
This will keep our current API working without having the users to change their codebases.
Also make sure we don't change the global state of our test suite.
rafaelfranca
force-pushed
the
params_parser_api
branch
from
5cb6385
to
4f30df4
Compare
rafaelfranca
added a commit
that referenced
this pull request
Feb 23, 2016
Make sure the parameter parsers register API work with overidden mime types.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if you want to add a new mime type to an existing type like
application/vnd.api+jsonit will not use the JSON parameter parser.The reason is that we use the
Mime::Typeobject as the key of the parameter parser hash.Here is an example of how an application use this behavior.
To fix it we changed the parameter parsers internal representation to use the
Mime::Type'ssymbolmethod.To not break the existing API, when instantiating the
ActionDispatch::ParamsParserwe acceptMime::Typeinstances but we change them to symbols.