extract ActionDispatch::IntegrationTest::Behavior #23880
Conversation
|
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @kaspth (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
Here is the rspec-rails pull request that would use this feature: rspec/rspec-rails#1560 |
|
This looks good but tests are broken. |
|
Interesting... something about |
bronson
force-pushed
the
extract-integration-behavior
branch
2 times, most recently
from
c184f8e
to
fbb70e3
Compare
|
Still not ready... I need to figure out the interaction between class variables and AS::Concern. |
bronson
force-pushed
the
extract-integration-behavior
branch
from
fbb70e3
to
b10d36d
Compare
|
@rafaelfranca, rebased against master and everything went green. Magic! Maybe some commit in the past week fixed it. Anything more I can do on this patch? |
Similar to 176fbfd, this makes it possible for other test frameworks to hook into Rails integration test facilities.
bronson
force-pushed
the
extract-integration-behavior
branch
from
b10d36d
to
4ca01d9
Compare
|
Rebased, fixed conflict, green again. |
extract ActionDispatch::IntegrationTest::Behavior
Similar to 176fbfd, this makes it possible for other test
frameworks to hook into Rails integration test facilities.
Also similar to d588bbd and 8e583b6