Deprecate Module.local_constants
#23936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @arthurnn (@rails-bot has picked a reviewer for you, use r? to override) |
|
That was a 1.8 compatibility method. We should remove it from the guide and deprecate it. |
|
I'm not sure what '1.8 compatibility method' means. |
|
In ruby 1.8, it was not so easy. Now, it shouldn't be used anywhere; we should change anything that does to just call |
yui-knk
force-pushed
the
local_constants_to_be_public
branch
from
2aea5ad
to
86d4e18
Compare
After Ruby 1.9, we can easily get the constants that have been defined locally by `Module.constants(false)`.
yui-knk
changed the title
Module.local_constants to be public APIModule.local_constants
|
@matthewd Updated! |
rafaelfranca
added a commit
that referenced
this pull request
Mar 1, 2016
Deprecate `Module.local_constants`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Module.local_constantsis treated as public API in 'Constans' sessionof Rails guide active_support_core_extensions. So it is better to remove
#:nodoc:.