Address ruby warnings #23951
Address ruby warnings #23951
Conversation
teoljungberg
commented
Feb 28, 2016
teoljungberg
commented
- Ambiguous first argument
- Mismatched indentation
|
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @kaspth (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
| @@ -15,7 +15,7 @@ def test_application_cable_skeleton_is_created | |||
| assert_file "app/channels/application_cable/connection.rb" do |cable| | |||
| assert_match(/module ApplicationCable\n class Connection < ActionCable::Connection::Base\n/, cable) | |||
| end | |||
| end | |||
| end | |||
There was a problem hiding this comment.
Now there's 3 spaces to the end above this. Is that intentional?
There was a problem hiding this comment.
Good catch, it's not.
I force pushed a change to remedy that fact.
- Ambiguous first argument - Mismatched indentation
teoljungberg
force-pushed
the
warning-free
branch
from
fb64d79
to
5a0dddd
Compare
|
Thanks! |
