Support faye-websocket + EventMachine as an option #23992
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
❤️ @pratik Will be back tomorrow to give that a try in production for BC3. On Wed, Mar 2, 2016 at 4:20 AM, Jeremy Daer notifications@github.com
|
matthewd
added a commit
that referenced
this pull request
Mar 3, 2016
Support faye-websocket + EventMachine as an option
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basecamp are seeing some weirdness when running on NIO sockets at load on production.
At least until we can investigate further, reproduce the problem in development, and attempt to fix it, let's offer the EventMachine/Faye connection management as an option.
cc @dhh @lifo