Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove outdated comment [ci skip] #24034

Merged
merged 1 commit into from
Mar 7, 2016
Merged

Remove outdated comment [ci skip] #24034

merged 1 commit into from
Mar 7, 2016

Conversation

kamipo
Copy link
Member

@kamipo kamipo commented Mar 3, 2016

Currently column options handled by the type map in Rails 4.2.

@kamipo
Remove outdated comment [ci skip]
45f06a7 
Currently column options handled by the type map in Rails 4.2.
@rails-bot
Copy link

r? @rafaelfranca

(@rails-bot has picked a reviewer for you, use r? to override)

@arthurnn
Copy link
Member

arthurnn commented Mar 7, 2016

The comment was added on 29b0707 but it came from 2a12b56. And I think it got invalid after c50cb4a or even before

arthurnn pushed a commit that referenced this pull request Mar 7, 2016
Merge pull request #24034 from kamipo/remove_outdated_comment
70e7b87 
Remove outdated comment [ci skip]
@arthurnn arthurnn merged commit 70e7b87 into rails:master Mar 7, 2016
@arthurnn
Copy link
Member

arthurnn commented Mar 7, 2016

thanks

@kamipo kamipo deleted the remove_outdated_comment branch March 7, 2016 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rafaelfranca rafaelfranca

Labels
activerecord docs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kamipo @rails-bot @arthurnn @rafaelfranca @maclover7