Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update base.rb [ci skip] #24045

Merged
merged 1 commit into from Mar 4, 2016
Merged

Update base.rb [ci skip] #24045

merged 1 commit into from Mar 4, 2016

Conversation

ghost
Copy link

@ghost ghost commented Mar 4, 2016

Replaces "over written" with "overwritten"

@rails-bot
Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @pixeltrix (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@kaspth
Copy link
Contributor

kaspth commented Mar 4, 2016

👋, @Sarah-Alsinan I noticed you put [ci skip] in the PR title (and in the PR description here #24044), but it has to be in your commit message for our CI to be skipped.

However, that doesn't block this at all and is just a nicety. Thanks, I'll merge!

kaspth added a commit that referenced this pull request Mar 4, 2016
@kaspth kaspth merged commit 86071a4 into rails:master Mar 4, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants