Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant regexp escapes in generators #24062

Merged
merged 1 commit into from
Mar 9, 2016
Merged

Remove redundant regexp escapes in generators #24062

merged 1 commit into from
Mar 9, 2016

Conversation

resure
Copy link

@resure resure commented Mar 4, 2016

Summary

Remove some redundant regexp escapes in generators, since _ is not a special character and can be used directly.

@rails-bot
Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @eileencodes (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@eileencodes
Copy link
Member

ActionCable tests are failing on this branch, is there a difference between Ruby 2.2.4 and 2.3.0 regex? Or maybe it's unrelated, I'm not sure.

@resure
Copy link
Author

resure commented Mar 8, 2016

I was unfortunate enough to fork broken master 💥

Looks like everything is ok now.

rafaelfranca added a commit that referenced this pull request Mar 9, 2016
Remove redundant regexp escapes in generators
@rafaelfranca rafaelfranca merged commit b165d73 into rails:master Mar 9, 2016
@resure resure deleted the redundant-escapes branch March 9, 2016 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants