Friendly error message if missing listen development dependency
#24067
Conversation
|
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @sgrif (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
| begin | ||
| require 'listen' | ||
| rescue LoadError => e | ||
| raise LoadError, "Could not load the 'listen' gem. Add `gem 'listen'` to the development section of your Gemfile", e.backtrace |
There was a problem hiding this comment.
I would replace "development section" with "development group" here as that is what its called in Gemfile.
There was a problem hiding this comment.
👍 to development group instead too.
Also, can you squash/force push this after you change it?
thanks
|
cc @fxn |
|
@arthurnn force pushed. Ready for review again |
…dependency Friendly error message if missing `listen` development dependency
|
Thanks |
Summary
This PR is a follow up to #24066. It prints a better error message for users who upgrade from a previous version of Rails and forget to specify or accidentally remove the
listengem.cc @dewski @rafaelfranca @arthurnn