Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove Rails 4 text from asset pipeline guide #24244

Merged
merged 1 commit into from
Mar 18, 2016

Conversation

bronson
Copy link
Contributor

@bronson bronson commented Mar 18, 2016

Probably no need to mention Rails 4 anymore. Also, a user was confused by the "no longer a core feature" language... Thought it meant that Sprockets had been deprecated.

This is just a suggestion, happy to revise.

@rails-bot
Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @pixeltrix (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.


You can disable the asset pipeline while creating a new application by
The asset pipeline is implemented by the
[sprockets-rails](https://github.com/rails/sprockets-rails) gem
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gem, and is enabled by default

@bronson
Copy link
Contributor Author

bronson commented Mar 18, 2016

@maclover7 agreed on all counts, fixed.

@maclover7
Copy link
Contributor

👍 Thank you for your contribution!

maclover7 added a commit that referenced this pull request Mar 18, 2016
remove Rails 4 text from asset pipeline guide
@maclover7 maclover7 merged commit dda31d5 into rails:master Mar 18, 2016
@maclover7
Copy link
Contributor

❤️ 💚 💙 💛 💜

In the future, please add [ci skip] to any commits that involve changing the documentation, to avoid running the entire Rails test suite.

@bronson
Copy link
Contributor Author

bronson commented Mar 18, 2016

That's good advice, will do. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants