Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

respect attribute default value as a block #24267

Closed
wants to merge 2 commits into from
Closed

respect attribute default value as a block #24267

wants to merge 2 commits into from

Conversation

Sen-Zhang
Copy link
Contributor

A propositional fix to issue #24249

@rails-bot
Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @schneems (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@maclover7
Copy link
Contributor

Hmm, this seems like more of a feature request than a bug report...

@Sen-Zhang
Copy link
Contributor Author

Oops, should I close this pull request for now?

@Sen-Zhang Sen-Zhang closed this Mar 22, 2016
@Sen-Zhang Sen-Zhang reopened this Mar 22, 2016
@rafaelfranca
Copy link
Member

r? @sgrif

@rails-bot rails-bot assigned sgrif and unassigned schneems Mar 24, 2016
@sgrif
Copy link
Contributor

sgrif commented Mar 24, 2016

I'm not a fan of this implementation. The solution is too far removed from the problem. I'd prefer to keep the handling of procs isolated to the area where it already occurs.

@Sen-Zhang Sen-Zhang closed this Mar 24, 2016
@Sen-Zhang Sen-Zhang deleted the attribute_default_value branch March 24, 2016 18:44
@Sen-Zhang Sen-Zhang restored the attribute_default_value branch March 24, 2016 18:44
@Sen-Zhang Sen-Zhang deleted the attribute_default_value branch March 24, 2016 18:44
@Sen-Zhang Sen-Zhang restored the attribute_default_value branch March 24, 2016 18:44
@Sen-Zhang
Copy link
Contributor Author

The new fix #24306 is just for tag helpers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants