Move sequence value methods to Model level #24292
Conversation
If we plan to make these things extention points to gems and applications we should remove the Other than that I'm fine with this change. |
I agree, I was not sure tho if we wanted to make this not private right at the first iteration. But It make sense.. I will document those methods. |
|
@rafaelfranca added the comments. |
| @@ -231,6 +231,19 @@ def sequence_name=(value) | |||
| @explicit_sequence_name = true | |||
| end | |||
|
|
|||
| # Should primary key values be selected from their corresponding | |||
There was a problem hiding this comment.
# Determines if the primary key values should be selected from their corresponding sequence before the insert statement.
`prefetch_primary_key?` and `next_sequence_value` methods live in the connection level at the moment, that make sense when you are generating the sequence from the database, in the same connection. Which is the use case today at the Oracle and Postgres adapters. However if you have an service that generates IDs, that has nothing to do with the database connection, and should not be fetched from there. Another use case, is if you want to use another connection to fetch IDs, that would not be possible with the current implementation, however when we move those methods to the model level, you can use a new connection there. Also this makes easier for gems to add behavior on those methods.
arthurnn
force-pushed
the
arthurnn/pk_sequence_klass
branch
from
2d57129
to
b6d1f68
Compare
|
@rafaelfranca docs updated. Thanks for the review |
Summary
prefetch_primary_key?andnext_sequence_valuemethods live in theconnection level at the moment, that make sense when you are generating
the sequence from the database, in the same connection. Which is the use
case today at the Oracle and Postgres adapters.
However if you have an service that generates IDs, that has nothing to
do with the database connection, and should not be fetched from there.
Another use case, is if you want to use another connection to fetch IDs,
that would not be possible with the current implementation, however when
we move those methods to the model level, you can use a new connection
there.
Also this makes easier for gems to add behavior on those methods.
review @jeremy @sgrif @rafaelfranca
cc @jesseplusplus