Do not show optional (.:format) block for wildcard route #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…state:resolved] This will make the output of `rake routes` to be correctly match to the behavior of the application, as the regular expression used to match the path is greedy and won't capture the format part by default This commit is the second attempt on fixing the issue, as the regular expression on another commit on `master` was invalid.
matthewd
pushed a commit
that referenced
this pull request
Apr 24, 2018
PostgreSQL bugfix for invalid SQL in subqueries
seanpdoyle
added a commit
to seanpdoyle/rails
that referenced
this pull request
Apr 13, 2021
Closes [@hotwired/turborails#243][]. Set the `useCapture` parameter of [addEventListener][] to `true` so that cancelling the event occurs early enough in the process so that the resulting upload is cancelled. [@hotwired/turborails#243]: hotwired/turbo#243 (comment) [addEventListener]: https://developer.mozilla.org/en-US/docs/Web/API/EventTarget/addEventListener#parameters Co-authored-by: Javan Makhmali <javan@basecamp.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not show optional (.:format) block for wildcard route [#6605 state:resolved]
This will make the output of
rake routesto be correctly match to the behavior of the application, as the regular expression used to match the path is greedy and won't capture the format part by defaultThis commit is the second attempt on fixing the issue, as the regular expression on another commit on
masterwas invalid.