Update Rails 5.0 release notes #24406
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prathamesh-sonpatki
changed the title
|
I had opened this PR for only updating about collection caching but while going through the guide found other issues also. |
prathamesh-sonpatki
force-pushed
the
update-release-notes
branch
from
6bb88b3
to
a45eac8
Compare
- Removed entry for # Template Collection from release notes. - Remove duplicate entry for caching Action mailer views. - Remove duplicate entry for left_outer_joins.
prathamesh-sonpatki
force-pushed
the
update-release-notes
branch
from
a45eac8
to
7d88ca6
Compare
| @@ -355,9 +351,6 @@ Please refer to the [Changelog][action-mailer] for detailed changes. | |||
| * Template lookup now respects default locale and I18n fallbacks. | |||
| ([commit](https://github.com/rails/rails/commit/ecb1981b)) | |||
|
|
|||
| * Template can use fragment cache like Action View template. | |||
| ([Pull Request](https://github.com/rails/rails/pull/22825)) | |||
|
|
|||
There was a problem hiding this comment.
Why should this be removed? I thought it was added in e40518f?
|
Turns out, I'm a dummy and should just read the commit message. Thanks, @prathamesh-sonpatki! 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.