Generate cable.js file if does not exist when generating channel
#24524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Before this, while generating a channel, we were not creating `cable.js` if it does not already exist. - We have similar code for application mailer here - rails@0b3ae02. - Based on the comment - rails#24418 (comment).
|
|
||
| App.cable = ActionCable.createConsumer(); | ||
|
|
||
| }).call(this); |
There was a problem hiding this comment.
We already have a cable.js in application templates in railties. Should we refer to it instead of duplicating here? I have seen similar duplicate file for application_mailer.rb too in mailer_generator template. We can remove duplicate file there too.
There was a problem hiding this comment.
No, we can't. Frameworks can't add dependencies in each other.
|
Dup of #24245? |
|
Jon, this PR was about making sure that we have |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cable.jsif it does not already exist.0b3ae02.
Rails 5 beta 3: Cannot read property 'subscriptions' of undefined #24418 (comment).
r? @jeremy