Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the Hash.to_xml with a lamda example #24626

Merged
merged 1 commit into from
Apr 19, 2016
Merged

Conversation

JustinJruby
Copy link
Contributor

Summary

Update the hash.to_xml example (with a lambda) to be more clear

The existing example isn't clear on how it works. The documentation is talking about how Hash.to_xml is used but the example makes it look like it's something to do with string.to_xml. And it raises the question why the lambda is used.

I updated the example to be more in line with what is being exampled.

Other Information

Update 'foo'.to_xml(lambda { |options, key| options[:builder].b(key) })
to {foo: lambda { |options, key| options[:builder].b(key) }}.to_xml

Update 'foo'.to_xml(lambda { |options, key| options[:builder].b(key) })
to  {foo: lambda { |options, key| options[:builder].b(key) }}.to_xml
@rails-bot
Copy link

Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @kaspth (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@maclover7
Copy link
Contributor

👍 Thank you for your contribution!

@maclover7 maclover7 merged commit ad95547 into rails:master Apr 19, 2016
@maclover7
Copy link
Contributor

❤️ 💚 💙 💛 💜

In the future, please add [ci skip] to any commits that involve changing the documentation, to avoid running the entire Rails test suite.

@JustinJruby
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants