Performance tests improved #247
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sing them (similarly to other constants)
…ting/performance, where it is actually required
… be overridden by each implementation
…n counting memory allocations under rubinius
…cribed in JRUBY-5650.
… only measuring wall clock for now (and the APIs will/can change, respectively)
|
@jeremy, can you take a look at this? |
|
It would be great if @jeremy could take a look at this, since he wrote most of the original code. I think @wycats had a brief look, but I'm not sure. Anyway, the easier way to start is to skim the new documentation (IMO): |
…nce_test Conflicts: activesupport/lib/active_support/testing/performance.rb
|
Merged with master (25288c1 didn't apply cleanly). |
…h the previous solution)
…upport for Rubinius and JRuby and high configurability)
|
I've changed both benchmarker and profiler to use the new performance testing tools. Consequently, they're more configurable and work under Rubinius and JRuby. I've also updated the guide (and uploaded a new version to the url I've sent before). |
…upport for Rubinius and JRuby and high configurability)
…o performance_test
|
Thanks for merging this in, Jeremy. |
matthewd
pushed a commit
that referenced
this pull request
Apr 24, 2018
fixed the readme per discussion w/ tenderlove
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
Last rubysoc I was halfway through adding support for benchmarking under Rubinius when I had to "abandon" the task because of the schedule (it was really low priority). I've been back at work on Rails' performance tests utilities and I've:
I've worked with Wayne to get the necessary MRI 1.8/1.9 patches on rvm. The last of them was merged yesterday.