generate mailer layout files if it does not already exist #25004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @eileencodes (@rails-bot has picked a reviewer for you, use r? to override) |
| <meta http-equiv="Content-Type" content="text/html; charset=utf-8" /> | ||
| <style> | ||
| /* Email styles need to be inline */ | ||
| </style> |
There was a problem hiding this comment.
I don't think adding empty style tags is necessary.
There was a problem hiding this comment.
The layout file of new rails app contains empty style tags.
https://github.com/rails/rails/blob/master/railties/lib/rails/generators/rails/app/templates/app/views/layouts/mailer.html.erb.tt#L5..L7
Should not make it the same?
There was a problem hiding this comment.
That's fine then, I didn't see that one. 👍
Currently, if `ApplicationMailer` does not exist, it is generated when run the mailer generator, but layouts files does not generate. However, because it uses the layouts in `ApplicationMailer`, layouts are required. Follow up to rails#24161
y-yagi
force-pushed
the
generate_mailer_layout_files_if_it_does_not_already_exist
branch
from
393007a
to
f0f4cb2
Compare
y-yagi
deleted the
generate_mailer_layout_files_if_it_does_not_already_exist
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, if
ApplicationMailerdoes not exist, it is generated whenrun the mailer generator, but layouts files does not generate.
However, because it uses the layouts in
ApplicationMailer,layouts are required.
Follow up to #24161