Safari 4 supports http only cookie #25053
Conversation
|
Thanks for the pull request, and welcome! The Rails team is excited to review your changes, and you should hear from @chancancode (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
| @@ -722,7 +722,7 @@ The log files on www.attacker.com will read like this: | |||
| GET http://www.attacker.com/_app_session=836c1c25278e5b321d6bea4f19cb57e2 | |||
| ``` | |||
|
|
|||
| You can mitigate these attacks (in the obvious way) by adding the **httpOnly** flag to cookies, so that document.cookie may not be read by JavaScript. Http only cookies can be used from IE v6.SP1, Firefox v2.0.0.5 and Opera 9.5. Safari is still considering, it ignores the option. But other, older browsers (such as WebTV and IE 5.5 on Mac) can actually cause the page to fail to load. Be warned that cookies [will still be visible using Ajax](https://www.owasp.org/index.php/HTTPOnly#Browsers_Supporting_HttpOnly), though. | |||
| You can mitigate these attacks (in the obvious way) by adding the **httpOnly** flag to cookies, so that document.cookie may not be read by JavaScript. Http only cookies can be used from IE v6.SP1, Firefox v2.0.0.5, Opera 9.5 and Safari 4. But other, older browsers (such as WebTV and IE 5.5 on Mac) can actually cause the page to fail to load. Be warned that cookies [will still be visible using Ajax](https://www.owasp.org/index.php/HTTPOnly#Browsers_Supporting_HttpOnly), though. | |||
|
|
|||
There was a problem hiding this comment.
Can you make it IE v6.SP1, Firefox v2.0.0.5, Opera 9.5 and Safari 4 onwards.
There was a problem hiding this comment.
Also Http only cookies --> HTTP only cookies.
There was a problem hiding this comment.
We can mention Chrome also? http://stackoverflow.com/a/528435/925734 ?
|
@matkoniecz Thanks. Few comments and then good to go. |
|
@prathamesh-sonpatki Done. |
|
@matkoniecz Thanks! Can you also squash the 2 commits and add As this is doc-only change, |
|
@prathamesh-sonpatki I think "commiter" is able to do this via GitHub UI right now (squash commits and edit message). |
|
I hadn't tried that on rails repo. But just did and I forgot to add |
small improvement to http://guides.rubyonrails.org/security.html
source: www.greebo.net/2009/06/09/httponly-in-safari-40-release/ via http://stackoverflow.com/questions/528405/which-browsers-do-support-httponly-cookies